Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #701: Add the OVER clause and include it in the Function tokens. #768

Merged
merged 2 commits into from
Apr 13, 2024
Merged

Fixes #701: Add the OVER clause and include it in the Function tokens. #768

merged 2 commits into from
Apr 13, 2024

Conversation

r33s3n6
Copy link
Contributor

@r33s3n6 r33s3n6 commented Mar 26, 2024 •
edited
Loading

Resolves #701

  • ran the tests (pytest)
  • all style issues addressed (flake8)
  • your changes are covered by tests
    (N/A) your changes are documented, if needed

Group tokens such as OVER exist_win or OVER (PARTITION BY...) as the OVER clause before grouping Identifier and Function. Extend tokens of Function to include the OVER clause if it is next to the Parenthesis of function parameters.

@andialbrecht andialbrecht added this to the 0.5.0 milestone Apr 13, 2024
@andialbrecht andialbrecht merged commit e03b74e into andialbrecht:master Apr 13, 2024
10 checks passed
@andialbrecht
Copy link
Owner

Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.5.0
Development

Successfully merging this pull request may close these issues.

Incorrect parsing of expressions in SELECT when "<Window Function> OVER ( ... )" is present
2 participants
@r33s3n6 @andialbrecht